Make TCP logstash work #284
Conversation
Currently, logstash.LogstashHandler is an alias for UDPLogstashHandler - thus, handler TCP is ignored, and glastopf always uses UDP logstash. This change makes it work properly.
Python logstash has a feature that lets you supply extra options to the logger. These extra options are in the format of a dictionary, and those get passed along to logstash and the rest of the chain. This patch breaks out the things that form the message, and supplies those as extra options. Without this - logstash users have to use a grok expression to split things out, and that's silly.
|
Also - I broke the log message components out into their constituent parts, and used a feature of python-logstash to send them to logstash. That makes ingest into logstash much simpler - it eliminates what would become a complicated grok statement, that probably wouldn't work that well anyway. |
|
Thanks for taking a look at this. If I'm not mistaken, if you are changing this line to |
|
Not sure exactly what's up at this point - the PHP includes configure finds for BFR seem to be very different from what my build found - I got: This one seems to have found a bunch of junk for PHP 5 maybe. |
|
Also - I need to check out SNARE/TANNER - didn't realize there was a successor to this project until I stumbled on mushmush.org |
|
Argh, this is related to the changes we did in BFR for PHP7. ignore the issues, I'll merge your PR and I might fix it some other time 👍 |
Currently, logstash.LogstashHandler is an alias for UDPLogstashHandler - thus, handler TCP is ignored, and glastopf always uses UDP logstash. This change makes it work properly.