-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tutorials: fix incipit tutorial #645
base: main
Are you sure you want to change the base?
tutorials: fix incipit tutorial #645
Conversation
@martha-thomae May I ask you to have a look at the updated Spanish translations? |
@martha-thomae Could you have a look please? |
pinging reviewers |
Thanks, Benni, Klaus, and Stefan, I will look at this during this week to get it done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor corrections for the writing in Spanish. And one extra paragraph that was missing in the Spanish translation of the English version. Thanks for all your work, @musicEnfanthen!
One small question (@musicEnfanthen, @rettinghaus, @bwbohl), do you remember how could I check from my own fork a branch of another person? Like this branch from Stefan, how can I see it on my fork to be able to run the website and see the changes locally? and also be able to actually make commits here? Thank you!
_tutorials-ES/102_incipit/step-12/102_incipit_step-12-desc.html
Outdated
Show resolved
Hide resolved
_tutorials-ES/102_incipit/step-12/102_incipit_step-12-desc.html
Outdated
Show resolved
Hide resolved
_tutorials-ES/102_incipit/step-12/102_incipit_step-12-desc.html
Outdated
Show resolved
Hide resolved
_tutorials-ES/102_incipit/step-12/102_incipit_step-12-desc.html
Outdated
Show resolved
Hide resolved
_tutorials-ES/102_incipit/step-12/102_incipit_step-12-desc.html
Outdated
Show resolved
Hide resolved
_tutorials-ES/102_incipit/step-12/102_incipit_step-12-desc.html
Outdated
Show resolved
Hide resolved
@martha-thomae In your above comments you can click the document with-+and- to add a suggestion for the marked lines and add your changes there. Theses then can be committed directly. I’ll make one example for the deletion of 'del ligado' above (#645 (comment)) |
@martha-thomae Thanks for your review. You can checkout any branch very easily by using gh cli tools: https://cli.github.com/ . You can then build the branch locally (see CONTRIBUTING.md for manual how to do that). To propose changes to this PR, as @bwbohl explained, you can click on the "Files changed" tab at the top of this PR and then click on the +/- signs at the beginning of a changed line. |
Co-authored-by: Benjamin W. Bohl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bwbohl and @musicEnfanthen for the help! I added now the actual changes :) thank you!
_tutorials-ES/102_incipit/step-12/102_incipit_step-12-desc.html
Outdated
Show resolved
Hide resolved
_tutorials-ES/102_incipit/step-12/102_incipit_step-12-desc.html
Outdated
Show resolved
Hide resolved
_tutorials-ES/102_incipit/step-12/102_incipit_step-12-desc.html
Outdated
Show resolved
Hide resolved
_tutorials-ES/102_incipit/step-12/102_incipit_step-12-desc.html
Outdated
Show resolved
Hide resolved
_tutorials-ES/102_incipit/step-12/102_incipit_step-12-desc.html
Outdated
Show resolved
Hide resolved
_tutorials-ES/102_incipit/step-12/102_incipit_step-12-desc.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be merged now :)
This PR adds some improvements for the incipit tutorial, including those proposed in #263 by @mfeustle .
This includes :
Fixes #263