Extend check-location to also compare basenames #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version of check-location examined the current directory (as a proxy for the directory in which the file calling check-location appears) to check if it is of the form */pdp-*/setNN but did not check the supplied base file name. This version uses the actual path to the calling file and additionally checks that the basename of the calling file matches the file name supplied to check-location. In order to obtain the path to the calling file, check-location is now a macro that captures the file's path and expands into a call to the function check-location-actual.
chwarr
reviewed
Oct 31, 2016
| stx)] | ||
| [else | ||
| (raise-syntax-error #f | ||
| "found a use of `check-location' that is not at the top level" |
There was a problem hiding this comment.
Might want to say something more like "in an unexpected location"
There was a problem hiding this comment.
While it is true, that message would not offer any guidance on how to fix the problem.
| (define set-folder (path->string (last path-elements))) | ||
| (define pdp-folder (path->string (list-ref path-elements (- path-len 2)))) | ||
| [(>= path-len 3) | ||
| (define actual-file-name (path->string (last path-elements))) |
There was a problem hiding this comment.
Consider (list-ref path-elements (- path-len 1)) for symmetry with the others instead of (last path-elements).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of check-location examined the current directory (as
a proxy for the directory in which the file calling check-location
appears) to check if it is of the form /pdp-/setNN but did not check
the supplied base file name. This version uses the actual path to the
calling file and additionally checks that the basename of the calling file
matches the file name supplied to check-location.
In order to obtain the path to the calling file, check-location is now a
macro that captures the file's path and expands into a call to the function
check-location-actual.