Do not open more than one migration or on-disk representation file at a time #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't come even close to fixing the issue, but felt like a good place to start.
This still doesn't solve the issue, but will likely play an important role, as code elsewhere won't have to worry about explicitly closing files when they're done with them. This shouldn't be a problem because we can't rewind file streams and because `hClose` can be called more than once on the same handle.
This is not a pretty implementation. Env vars to be templated are stored in each `SqlMigration` object (both their names and values), and one of the functions that return migrations and streams from disk higher up in the internal layers of the codebase now reads that, closes the stream it had before and opens a new one. That new FileStream is returned by calling the parser again and overriding specific parts of the returned record, assuming the file won't change in between the two moments it is opened (I don't think we can escape this assumption regardless of implementation if we want to parse+report errors in migrations before we start applying them).
And cleanup argv handling in the Runfile
Because they will obviously fail without strace-wrapping, and it's not worth implementing it for them.
mzabani
force-pushed
the
issue-172-open-only-one-migration-at-a-time
branch
from
aeec6eb to
622244a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #172 and adds a test to assert this never happens again