-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(core): Patch Bull to include stack trace on job fail (#12547)
- Loading branch information
Showing
3 changed files
with
27 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -90,6 +90,7 @@ | |
"ws": ">=8.17.1" | ||
}, | ||
"patchedDependencies": { | ||
"[email protected]": "patches/[email protected]", | ||
"[email protected]": "patches/[email protected]", | ||
"[email protected]": "patches/[email protected]", | ||
"@types/[email protected]": "patches/@[email protected]", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
diff --git a/lib/job.js b/lib/job.js | ||
index 6a3606974fd3e397c6c5b2b6e65b20670c68f753..4cdbed1d564ceeb5a80c92eb605e49cfd3c8ccdd 100644 | ||
--- a/lib/job.js | ||
+++ b/lib/job.js | ||
@@ -511,9 +511,14 @@ Job.prototype.finished = async function() { | ||
} | ||
}; | ||
|
||
- const onFailed = (jobId, failedReason) => { | ||
+ const onFailed = async (jobId, failedReason) => { | ||
if (String(jobId) === String(this.id)) { | ||
- reject(new Error(failedReason)); | ||
+ const job = await Job.fromId(this.queue, this.id); | ||
+ const error = new Error(failedReason); | ||
+ if (job && job.stacktrace && job.stacktrace.length > 0) { | ||
+ error.stack = job.stacktrace.join('\n'); | ||
+ } | ||
+ reject(error); | ||
removeListeners(); | ||
} | ||
}; |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.