Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Jira Software Node): Personal Access Token credential type #11038

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

GKdeVries
Copy link
Contributor

@GKdeVries GKdeVries commented Oct 1, 2024

Summary

The company where I'm working at, is switching really soon to SSO only, this means that I can't use the basic authentication method anymore with Jira Rest calls. So I've added the Personal Access Token option to the current Jira node code.

n8n add jira pat credential

Related Linear tickets, Github issues, and Community forum posts

I've talked about it (shortly) in the following feature request: (https://community.n8n.io/t/jira-data-center-personal-access-token-auth-type/45579).
But the timetables where shortend a lot and change to sso is already next week, so I've took this change upon myself.

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@CLAassistant
Copy link

CLAassistant commented Oct 1, 2024

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request in linear Issue or PR has been created in Linear for internal review labels Oct 1, 2024
@Joffcom
Copy link
Member

Joffcom commented Oct 1, 2024

Hey @GKdeVries,

Thanks for the PR, We have created "GHC-274" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

@SLedunois
Copy link

Awesome. We need this feature !

Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@lure8225
Copy link

Any update here? Would be greate to have this, currently stops me from investigating n8n for us as password sign in is disabled for our instance

@GKdeVries
Copy link
Contributor Author

Is there any progress? Since there are more and more Jira instances of other users moving from basic auth to PAT authentication.
Or there something I need to do?

@netroy netroy changed the title feat(Jira Node): Added Personal Access Token credential type feat(Jira Software Node): Added Personal Access Token credential type Jan 22, 2025
@GKdeVries GKdeVries changed the title feat(Jira Software Node): Added Personal Access Token credential type feat(Jira Software Node): Personal Access Token credential type Jan 22, 2025
@netroy netroy merged commit 1c7a38f into n8n-io:master Jan 22, 2025
20 of 23 checks passed
@github-actions github-actions bot mentioned this pull request Jan 22, 2025
@janober
Copy link
Member

janober commented Jan 22, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants