Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(n8n AWS Cognito Node): New node #11767

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

valentina98
Copy link
Contributor

Summary

Adds AWS Cognito node. You can find the API documentation here.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request node/new Creation of an entirely new node in linear Issue or PR has been created in Linear for internal review labels Nov 17, 2024
@Joffcom
Copy link
Member

Joffcom commented Nov 17, 2024

Hey @valentina98,

Thanks for the PR, We have created "GHC-455" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

@valentina98 valentina98 changed the title WIP: feat(n8n AWS Cognito Node): New node feat(n8n AWS Cognito Node): New node Dec 14, 2024
@@ -354,6 +354,7 @@ export class Aws implements ICredentialType {
} else if (service === 'rekognition' && credentials.rekognitionEndpoint) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add validation to ensure service is defined and valid before constructing the endpoint string.

Comment on lines 31 to 40
hints: [
{
message: 'Please select a parameter in the options to update the user',
displayCondition:
'={{$parameter["resource"] === "user" && $parameter["operation"] === "update" && Object.keys($parameter["additionalOptions"]).length === 0}}',
whenToDisplay: 'always',
location: 'outputPane',
type: 'warning',
},
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use concise messages like "Select a parameter to update this resource" to improve clarity.

@adina-hub
Copy link
Contributor

adina-hub commented Jan 24, 2025

@Parvezkhan0 @netroy this node is still in a review phase, please wait for confirmation to continue.

@@ -353,8 +353,6 @@ export class Aws implements ICredentialType {
endpointString = credentials.sesEndpoint;
} else if (service === 'rekognition' && credentials.rekognitionEndpoint) {
endpointString = credentials.rekognitionEndpoint;
} else if (service === 'sqs' && credentials.sqsEndpoint) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these lines removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a duplicate, there was also a comment previously with this as a to-do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request node/new Creation of an entirely new node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants