-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(n8n AWS Cognito Node): New node #11767
base: master
Are you sure you want to change the base?
Conversation
Hey @valentina98, Thanks for the PR, We have created "GHC-455" as the internal reference to get this reviewed. One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team. |
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
…into node-aws-cognito
…into node-aws-cognito
…into node-aws-cognito
…itionalFields' for Group
@@ -354,6 +354,7 @@ export class Aws implements ICredentialType { | |||
} else if (service === 'rekognition' && credentials.rekognitionEndpoint) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add validation to ensure service is defined and valid before constructing the endpoint string.
hints: [ | ||
{ | ||
message: 'Please select a parameter in the options to update the user', | ||
displayCondition: | ||
'={{$parameter["resource"] === "user" && $parameter["operation"] === "update" && Object.keys($parameter["additionalOptions"]).length === 0}}', | ||
whenToDisplay: 'always', | ||
location: 'outputPane', | ||
type: 'warning', | ||
}, | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use concise messages like "Select a parameter to update this resource" to improve clarity.
@Parvezkhan0 @netroy this node is still in a review phase, please wait for confirmation to continue. |
@@ -353,8 +353,6 @@ export class Aws implements ICredentialType { | |||
endpointString = credentials.sesEndpoint; | |||
} else if (service === 'rekognition' && credentials.rekognitionEndpoint) { | |||
endpointString = credentials.rekognitionEndpoint; | |||
} else if (service === 'sqs' && credentials.sqsEndpoint) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these lines removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a duplicate, there was also a comment previously with this as a to-do
Summary
Adds AWS Cognito node. You can find the API documentation here.