Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Make placeholders in manual executions in workers temporary #12463

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jan 6, 2025

Summary

Please see details in story.

To test:

  1. Get workflow and payload attached in Slack.
  2. Set up a dummy server:
mkdir ~/Downloads/dummy
mv ~/Downloads/large-wf-data.json ~/Downloads/dummy
cd ~/Downloads/dummy
python3 -m http.server 3000
  1. Start a main in queue mode with OFFLOAD_MANUAL_EXECUTIONS_TO_WORKERS=true and import the workflow.
  2. Start a worker.
  3. Run the workflow manually.

Expected: See acceptance criteria in the story.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/PAY-2429

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 30.90909% with 38 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ges/editor-ui/src/composables/usePushConnection.ts 16.66% 20 Missing ⚠️
packages/editor-ui/src/components/RunData.vue 18.18% 9 Missing ⚠️
packages/cli/src/push/index.ts 0.00% 5 Missing ⚠️
packages/editor-ui/src/stores/workflows.store.ts 50.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 6, 2025
@@ -230,11 +230,33 @@ export function usePushConnection({ router }: { router: ReturnType<typeof useRou
return false;
}

let showedSuccessToast = false;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is not ideal, but it minimizes the extent of changes to make. pushMessageReceived is in dire need of refactoring.

@ivov ivov marked this pull request as ready for review January 7, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant