Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Hide credential’s modal menu when the credential is managed (no-changelog) #12471

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Jan 6, 2025

Summary

Fix one of the point in the feedback about the free AI credits.

Before

CleanShot 2025-01-06 at 09 30 46@2x

Now

CleanShot 2025-01-06 at 09 30 03@2x

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@RicardoE105 RicardoE105 changed the title Hide credential's modal menu when credential is managed fix(editor): Hide credential's modal menu when credential is managed Jan 6, 2025
@RicardoE105 RicardoE105 changed the title fix(editor): Hide credential's modal menu when credential is managed fix(editor): Hide credential's modal menu when credential is managed (no-changelog) Jan 6, 2025
@RicardoE105 RicardoE105 changed the title fix(editor): Hide credential's modal menu when credential is managed (no-changelog) fix(editor): Hide credential’s modal menu when the credential is managed (no-changelog) Jan 6, 2025
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 6, 2025
@RicardoE105 RicardoE105 requested a review from mutdmour January 6, 2025 14:32
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

github-actions bot commented Jan 6, 2025

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jan 6, 2025

n8n    Run #8597

Run Properties:  status check passed Passed #8597  •  git commit f609371257: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project n8n
Branch Review master
Run status status check passed Passed #8597
Run duration 04m 55s
Commit git commit f609371257: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Committer Ricardo Espinoza
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 485
View all changes introduced in this branch ↗︎

@RicardoE105 RicardoE105 merged commit f609371 into master Jan 6, 2025
43 checks passed
@RicardoE105 RicardoE105 deleted the hide-menu-with-managed-credentials branch January 6, 2025 15:37
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with [email protected]

1 similar comment
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with [email protected]

@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with [email protected]

1 similar comment
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants