Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(editor): Add deprecation warnings for e2e page classes (no-changelog) #12489

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

OlegIvaniv
Copy link
Contributor

Summary

  • Add deprecation warning for e2e page classes
  • Add getWorkflowHistoryCloseButton() function to workflow composables
  • Remove WorkflowHistoryPage, BannerStack, SettingsUsagePage and SettingsPages
  • Update references in editor tests to use new composable function

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link

cypress bot commented Jan 7, 2025

n8n    Run #8641

Run Properties:  status check passed Passed #8641  •  git commit 35d4ddd00b: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project n8n
Branch Review chore_deprecate_old_e2e_classes
Run status status check passed Passed #8641
Run duration 04m 56s
Commit git commit 35d4ddd00b: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Committer Oleg Ivaniv
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 489
View all changes introduced in this branch ↗︎

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jan 7, 2025
@OlegIvaniv OlegIvaniv changed the title refactor(tests): Add deprecation warnings for e2e page classes (no-changelog) tests(editor): Add deprecation warnings for e2e page classes (no-changelog) Jan 7, 2025
@OlegIvaniv OlegIvaniv changed the title tests(editor): Add deprecation warnings for e2e page classes (no-changelog) test(editor): Add deprecation warnings for e2e page classes (no-changelog) Jan 7, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

github-actions bot commented Jan 8, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

github-actions bot commented Jan 8, 2025

✅ All Cypress E2E specs passed

@OlegIvaniv OlegIvaniv merged commit 803960e into master Jan 8, 2025
37 checks passed
@OlegIvaniv OlegIvaniv deleted the chore_deprecate_old_e2e_classes branch January 8, 2025 08:36
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants