Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): Mark item.index as deprecated #12494

Merged
merged 2 commits into from
Jan 8, 2025
Merged

chore(core): Mark item.index as deprecated #12494

merged 2 commits into from
Jan 8, 2025

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jan 8, 2025

Follow-up to #12469

@ivov ivov changed the title Mark item index as deprecated chore(core): Mark item.index as deprecated Jan 8, 2025
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jan 8, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@cypress Cypress
Copy link

cypress bot commented Jan 8, 2025

n8n    Run #8644

Run Properties:  status check passed Passed #8644  •  git commit fd2d4f7a0b: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project n8n
Branch Review mark-item-index-as-deprecated
Run status status check passed Passed #8644
Run duration 04m 51s
Commit git commit fd2d4f7a0b: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Committer Iván Ovejero
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 485
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

✅ All Cypress E2E specs passed

@ivov ivov merged commit ac497c8 into master Jan 8, 2025
38 checks passed
@ivov ivov deleted the mark-item-index-as-deprecated branch January 8, 2025 10:26
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with [email protected]

riascho pushed a commit that referenced this pull request Jan 14, 2025
@ivov @riascho
chore(core): Mark item.index as deprecated (#12494)
c2ed1eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivov @janober @netroy