Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Make node credential select searchable #12497

Merged
merged 8 commits into from
Jan 10, 2025

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Jan 8, 2025

Summary

image image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2215/make-credential-select-searchable

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...kages/editor-ui/src/components/NodeCredentials.vue 93.93% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good 🎉
only one visual issue when hovering over create new credential the last credential has a highlighted background despite that I am not hovering over it
Screenshot 2025-01-08 at 15 40 12

ShireenMissi
ShireenMissi previously approved these changes Jan 9, 2025
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

github-actions bot commented Jan 9, 2025

✅ No visual regressions found.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Jan 9, 2025

n8n    Run #8702

Run Properties:  status check passed Passed #8702  •  git commit 741eb63cf0: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project n8n
Branch Review node-2215-make-credential-select-searchable
Run status status check passed Passed #8702
Run duration 04m 50s
Commit git commit 741eb63cf0: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Committer Elias Meire
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 489
View all changes introduced in this branch ↗︎

ShireenMissi
ShireenMissi previously approved these changes Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

✅ No visual regressions found.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

✅ No visual regressions found.

Copy link
Contributor

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit 91277c4 into master Jan 10, 2025
41 checks passed
@elsmr elsmr deleted the node-2215-make-credential-select-searchable branch January 10, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants