Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Update filter and feedback for source control #12504

Merged

Conversation

r00gm
Copy link
Contributor

@r00gm r00gm commented Jan 8, 2025

Summary

  • Credential Filters now sync with URL query params
  • Added filter to match credentials in need of setup
  • Improved User feedback regarding source control

image

image

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@r00gm r00gm changed the title fWIP: credentials filter WIP: credentials filter Jan 8, 2025
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 8, 2025
@r00gm r00gm changed the title WIP: credentials filter fix(editor): Update filter and feedback for source control Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

@r00gm r00gm marked this pull request as ready for review January 9, 2025 16:09
@r00gm r00gm requested a review from cstuncsik January 9, 2025 16:09
cstuncsik
cstuncsik previously approved these changes Jan 10, 2025
Copy link

cypress bot commented Jan 10, 2025

n8n    Run #8718

Run Properties:  status check passed Passed #8718  •  git commit 2b1855cd46: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 r00gm 🗃️ e2e/*
Project n8n
Branch Review pay-1804-updated-filter-and-feedback-for-users-working-with-new
Run status status check passed Passed #8718
Run duration 04m 53s
Commit git commit 2b1855cd46: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 r00gm 🗃️ e2e/*
Committer r00gm
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 489
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link
Contributor

✅ All Cypress E2E specs passed

@r00gm r00gm merged commit 865fc21 into master Jan 13, 2025
37 checks passed
@r00gm r00gm deleted the pay-1804-updated-filter-and-feedback-for-users-working-with-new branch January 13, 2025 09:24
@github-actions github-actions bot mentioned this pull request Jan 15, 2025
@janober
Copy link
Member

janober commented Jan 15, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants