Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editor): Persist sidebar collapsed status preference #12505

Merged
merged 4 commits into from
Jan 8, 2025
Merged

feat(editor): Persist sidebar collapsed status preference #12505

merged 4 commits into from
Jan 8, 2025

Conversation

alexgrozav
Copy link
Member

Summary

  • Keeps sidebar collapsed status preference on reload
  • Seamlessly collapses sidebar on small window widths and reverts to preference on resize
Screen.Recording.2025-01-08.at.14.38.50.mov

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CAT-493/persist-sidebar-collapsed-status

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Jan 8, 2025
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 8, 2025
r00gm
r00gm previously approved these changes Jan 8, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/editor-ui/src/stores/ui.store.ts 50.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress Cypress
Copy link

cypress bot commented Jan 8, 2025 •
edited
Loading

n8n    Run #8661

Run Properties:  status check passed Passed #8661  •  git commit bd1f7afca3: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review cat-493-persist-sidebar-collapsed-status
Run status status check passed Passed #8661
Run duration 04m 57s
Commit git commit bd1f7afca3: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 489
View all changes introduced in this branch ↗︎

@alexgrozav alexgrozav requested a review from r00gm January 8, 2025 14:04
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit dba7d46 into master Jan 8, 2025
38 checks passed
@alexgrozav alexgrozav deleted the cat-493-persist-sidebar-collapsed-status branch January 8, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy left review comments

@r00gm r00gm r00gm approved these changes

Assignees

@alexgrozav alexgrozav

Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexgrozav @netroy @r00gm