fix(editor): Fix workflow initilisation for test definition routes & add unit tests #12507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ditView and remove tooltips
…for test definitions, make sure to initialize workflow on the root route
n8n-assistant
bot
added
n8n team
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
burivuhster
approved these changes
Jan 8, 2025
|
|
||
| async function initWorkflow() { | ||
| const workflowId = router.currentRoute.value.params.name as string; | ||
| const isAlreadyInitialized = workflowStore.workflow.id === workflowId; |
There was a problem hiding this comment.
Could it be already in the process of fetching workflow at this point? isAlreadyInitialized will still be false in that case and the second request will be triggered.
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ai-567-update-ui-copy
|
| Run status |
|
| Run duration | 04m 55s |
| Commit |
|
| Committer | Oleg Ivaniv |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
489
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the Test Definition UI by:
TestDefinitionRootViewcomponent to properly initialize workflows and handle nested routingNodesPinningandTestDefinitionRootViewcomponentsRelated Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)