Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix NDV resize handle and scrollbar overlapping #12509

Merged

Conversation

alexgrozav
Copy link
Member

Summary

  • Added outset prop to resize wrapper
  • Resize handles are now positioned outside the element

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CAT-495/fix-ndv-resize-and-scrolling-overlapping

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Member

@elsmr elsmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean! ✨

Copy link
Contributor

github-actions bot commented Jan 8, 2025

✅ No visual regressions found.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 8, 2025
Copy link

cypress bot commented Jan 8, 2025

n8n    Run #8660

Run Properties:  status check passed Passed #8660  •  git commit 47a32f89a1: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review cat-495-fix-ndv-resize-and-scrolling-overlapping
Run status status check passed Passed #8660
Run duration 04m 53s
Commit git commit 47a32f89a1: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 489
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Jan 8, 2025

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit c28f302 into master Jan 8, 2025
39 of 40 checks passed
@alexgrozav alexgrozav deleted the cat-495-fix-ndv-resize-and-scrolling-overlapping branch January 8, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants