Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Condition to show the warning after workflow activation for free AI credits (no-changelog) #12518

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Jan 8, 2025

Summary

  1. Addresses bug found during review due to the workflowsStore.workflow.usedCredentials not set all the time. This PR instead relies on the workflowsStore.usedCredentials.
  2. Addresses use case when the node with the free AI credentials is disabled. If that case, do not show the warning.
  3. Add more tests]]

Demo:

CleanShot 2025-01-08 at 16 41 31

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@RicardoE105 RicardoE105 changed the title Fix condition to show the warning after workflow activation for free ai credits fix(editor): Condition to show the warning after workflow activation for free AI credits (no-changelog) Jan 8, 2025
@RicardoE105 RicardoE105 requested a review from mutdmour January 8, 2025 19:03
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ges/editor-ui/src/components/WorkflowActivator.vue 95.23% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

github-actions bot commented Jan 9, 2025

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jan 9, 2025

n8n    Run #8667

Run Properties:  status check passed Passed #8667  •  git commit 07c01df967: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Project n8n
Branch Review fix-warning-for-free-ai-credits-feature
Run status status check passed Passed #8667
Run duration 04m 57s
Commit git commit 07c01df967: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Committer Ricardo Espinoza
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 489
View all changes introduced in this branch ↗︎

@RicardoE105 RicardoE105 merged commit 46f13cf into master Jan 9, 2025
40 checks passed
@RicardoE105 RicardoE105 deleted the fix-warning-for-free-ai-credits-feature branch January 9, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants