fix(core): Fix node exclusion on the frontend types #12544
Merged
+32
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
netroy
commented
Jan 9, 2025
| @@ -654,18 +645,6 @@ describe('DirectoryLoader', () => { | |||
| expect(nodeWithIcon.description.icon).toBeUndefined(); | |||
| }); | |||
|
|
|||
| it('should skip node if included in excludeNodes', () => { | |||
| const loader = new CustomDirectoryLoader(directory, ['CUSTOM.node1']); | |||
There was a problem hiding this comment.
removed this because now exclusion doesn't work for custom nodes. If someone is adding custom nodes to their instance, and doesn't want it to be used, they can simply remove the node.
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
MarcL
approved these changes
Jan 10, 2025
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
CAT-505-fix-node-exclusion
|
| Run status |
|
| Run duration | 04m 55s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
489
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CAT-505
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)