test: Update e2e tests for canvas specific actions (no-changelog) #12614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgrozav
changed the title
n8n-assistant
bot
added
n8n team
OlegIvaniv
reviewed
Jan 15, 2025
| cy.get(draggableSelector).trigger('mousedown'); | ||
| cy.ifCanvasVersion( | ||
| () => { | ||
| // We can't use realMouseDown here because it hangs headless run |
There was a problem hiding this comment.
Seems like this comment is no longer relevant. At least locally realMouseDown no longer hangs the tests. So perhaps we could simplify this by always using it?
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
OlegIvaniv
previously approved these changes
Jan 16, 2025
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
cat-525-12-canvas
|
| Run status |
|
| Run duration | 05m 08s |
| Commit |
|
| Committer | Alex Grozav |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
491
|
| View all changes introduced in this branch ↗︎ | |
OlegIvaniv
previously approved these changes
Jan 17, 2025
|
|
OlegIvaniv
previously approved these changes
Jan 20, 2025
|
|
OlegIvaniv
previously approved these changes
Jan 20, 2025
|
|
|
|
tomi
approved these changes
Jan 21, 2025
|
✅ All Cypress E2E specs passed |
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-525/12-canvas
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)