chore(API): Add styling to credential callback and autoclose window #12648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dana-gill
changed the title
dana-gill
changed the title
dana-gill
changed the title
n8n-assistant
bot
added
core
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
dana-gill
force-pushed
the
node-1514-google-oauth-confirmation-modal-re-add-auto-close
branch
from
23a7866 to
0472fde
Compare
Due to the nature of rendering handlebar files, it's a bit of a challenge to incorporate custom font styles. Hence, we are using sans-serif
Joffcom
reviewed
Jan 20, 2025
dana-gill
force-pushed
the
node-1514-google-oauth-confirmation-modal-re-add-auto-close
branch
from
0472fde to
9a38450
Compare
Joffcom
approved these changes
Jan 21, 2025
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
node-1514-google-oauth-confirmation-modal-re-add-auto-close
|
| Run status |
|
| Run duration | 04m 48s |
| Commit |
|
| Committer | Dana Lee |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
489
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
dana-gill
deleted the
node-1514-google-oauth-confirmation-modal-re-add-auto-close
branch
|
Got released with |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add styling to credential callback and autoclose window. This looks more professional and also is a small reward for users setting up credentials
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1514/google-oauth-confirmation-modal-re-add-auto-close
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)