Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Jira Software Node): Get custom fields(RLC) in update operation for server deployment type #12719

Conversation

michael-radency
Copy link
Contributor

Summary

this allows to fetch custom fields in update operation in RLC

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1619/community-issue-jira-node-list-custom-fields-not-working
#10522

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Jan 20, 2025
@dana-gill dana-gill self-requested a review January 20, 2025 08:43
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/nodes-base/nodes/Jira/Jira.node.ts 88.88% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@dana-gill dana-gill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this :) Could you also write a test for getCustomFields just to check that ?

issueId = res.id;
}

if (jiraVersion === 'server' && operation === 'update' && issueId) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this also be enabled for a Cloud Jira? Maybe I'm missing something, but I don't see anything in the Jira docs that suggests that this isn't possible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer not to do that as it is workaround for specific case and it does not work with create operation

…community-issue-jira-node-list-custom-fields-not-working
…community-issue-jira-node-list-custom-fields-not-working
Copy link
Contributor

@dana-gill dana-gill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to test this locally since self-hosted Jira is a quite difficult to setup, but based on the tests, it looks like it should work -- lgtm 🥳

Copy link

cypress bot commented Jan 21, 2025

n8n    Run #8867

Run Properties:  status check passed Passed #8867  •  git commit ae78144608: 🌳 ci-trial-blacksmith 🖥️ browsers:node18.12.0-chrome107 🤖 schedule 🗃️ e2e/*
Project n8n
Branch Review ci-trial-blacksmith
Run status status check passed Passed #8867
Run duration 05m 00s
Commit git commit ae78144608: 🌳 ci-trial-blacksmith 🖥️ browsers:node18.12.0-chrome107 🤖 schedule 🗃️ e2e/*
Committer Tomi Turtiainen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 491
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 353df79 into master Jan 21, 2025
37 checks passed
@michael-radency michael-radency deleted the node-1619-community-issue-jira-node-list-custom-fields-not-working branch January 21, 2025 12:01
@github-actions github-actions bot mentioned this pull request Jan 22, 2025
@janober
Copy link
Member

janober commented Jan 22, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants