-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Jira Software Node): Get custom fields(RLC) in update operation for server deployment type #12719
fix(Jira Software Node): Get custom fields(RLC) in update operation for server deployment type #12719
Conversation
…community-issue-form-redirection-to-form-waiting-is-not
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this :) Could you also write a test for getCustomFields
just to check that ?
issueId = res.id; | ||
} | ||
|
||
if (jiraVersion === 'server' && operation === 'update' && issueId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this also be enabled for a Cloud Jira? Maybe I'm missing something, but I don't see anything in the Jira docs that suggests that this isn't possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer not to do that as it is workaround for specific case and it does not work with create operation
…community-issue-jira-node-list-custom-fields-not-working
…community-issue-jira-node-list-custom-fields-not-working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to test this locally since self-hosted Jira is a quite difficult to setup, but based on the tests, it looks like it should work -- lgtm 🥳
n8n Run #8867
Run Properties:
|
Project |
n8n
|
Branch Review |
ci-trial-blacksmith
|
Run status |
Passed #8867
|
Run duration | 05m 00s |
Commit |
ae78144608: 🌳 ci-trial-blacksmith 🖥️ browsers:node18.12.0-chrome107 🤖 schedule 🗃️ e2e/*
|
Committer | Tomi Turtiainen |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
2
|
Pending |
0
|
Skipped |
0
|
Passing |
491
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
Got released with |
Summary
this allows to fetch custom fields in update operation in RLC
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1619/community-issue-jira-node-list-custom-fields-not-working
#10522