fix(OpenAI Chat Model Node): Restore default model value #12745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
n8n
|
||||||||||||||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
enable-task-runner-by-default
|
| Run status |
|
| Run duration | 04m 40s |
| Commit |
|
| Committer | Tomi Turtiainen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
2
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
332
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
39-projects.cy.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Projects > when starting from scratch > should move resources between projects |
Test Replay
Screenshots
Video
|
|
12-canvas-actions.cy.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Canvas Actions > Node hover actions > should execute node |
Test Replay
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 45 specs in Cypress Cloud.
|
✅ All Cypress E2E specs passed |
OlegIvaniv
deleted the
ai-614-openai-chat-model-node-missing-default-model-value
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #12634 we changed the model field to use
resourceLocatorparameter type in a new version of the node. But we didn't update thedefault.valueto match the behaviour from previous version(usinggpt-4o-minias default)Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)