-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Handle large payloads in the AI Assistant requests better #12747
fix(editor): Handle large payloads in the AI Assistant requests better #12747
Conversation
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please add more tests? This PR seems lacking in terms of coverage.
Alright, there are a few important bits that can be tested still. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding tests
n8n Run #8887
Run Properties:
|
Project |
n8n
|
Branch Review |
ADO-3055-ai-assistant-large-payload-handle
|
Run status |
Passed #8887
|
Run duration | 04m 38s |
Commit |
e0d8e122f9: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
|
Committer | Milorad FIlipović |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
491
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
Summary
Internal Server Error
:How to test:
Details are in this Linear comment.
Related Linear tickets, Github issues, and Community forum posts
Fixes ADO-3055
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)