Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Handle large payloads in the AI Assistant requests better #12747

Merged
merged 13 commits into from
Jan 22, 2025

Conversation

MiloradFilipovic
Copy link
Contributor

Summary

  1. Handling large payloads in AI assistant requests by trimming node parameters
  2. Streaming the original error message from the server instead of always showing the generic Internal Server Error:
    image

How to test:

Details are in this Linear comment.

Related Linear tickets, Github issues, and Community forum posts

Fixes ADO-3055

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@MiloradFilipovic MiloradFilipovic self-assigned this Jan 21, 2025
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add more tests? This PR seems lacking in terms of coverage.

@MiloradFilipovic
Copy link
Contributor Author

Can we please add more tests? This PR seems lacking in terms of coverage.

Alright, there are a few important bits that can be tested still.

Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding tests

Copy link

cypress bot commented Jan 22, 2025

n8n    Run #8887

Run Properties:  status check passed Passed #8887  •  git commit e0d8e122f9: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Project n8n
Branch Review ADO-3055-ai-assistant-large-payload-handle
Run status status check passed Passed #8887
Run duration 04m 38s
Commit git commit e0d8e122f9: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Committer Milorad FIlipović
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 491
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic merged commit eb4dea1 into master Jan 22, 2025
37 checks passed
@MiloradFilipovic MiloradFilipovic deleted the ADO-3055-ai-assistant-large-payload-handle branch January 22, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants