Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Make task broker an explicit component of task runner #12782

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomi
Copy link
Contributor

@tomi tomi commented Jan 22, 2025

Summary

Rename TaskRunnerServer to TaskBrokerServer and move to own dir. Same for TaskRunnerWsServer. No code changes, only moving files and renaming classes.

As discussed in this PR

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...-runners/task-broker/errors/task-deferred.error.ts 50.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@tomi tomi changed the title reafactor(core): Make task broker an explicit component of task runner refactor(core): Make task broker an explicit component of task runner Jan 22, 2025
Rename `TaskRunnerServer` to `TaskBrokerServer` and move to own dir. Same for
`TaskRunnerWsServer`. No code changes, only moving files and renaming classes.
@tomi tomi force-pushed the refactor-rename-task-runner-server-to-task-broker branch from 4750d5d to ad691a0 Compare January 22, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant