update webpack plugin #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stas-nc
requested review from
m2broth,
blackrabbit99,
b1ff,
yehor-manzhula and
harnyk
stas-nc
force-pushed
the
chore/update-webpack-plugin
branch
from
3f4f8f5 to
de573d7
Compare
b1ff
approved these changes
Dec 30, 2024
stas-nc
force-pushed
the
chore/update-webpack-plugin
branch
2 times, most recently
from
1a3d9d4 to
87875b4
Compare
BREAKING CHANGE: requires webpack >=5 fixes #58
stas-nc
force-pushed
the
chore/update-webpack-plugin
branch
from
87875b4 to
46b8b3a
Compare
| @@ -7,6 +7,7 @@ | |||
| "functions": 90, | |||
| "statements": 90, | |||
| "exclude": [ | |||
| "test/**" | |||
| "test/**", | |||
| "src/app/utils/resolveDirectory.ts" | |||
There was a problem hiding this comment.
Why do we need that?
There was a problem hiding this comment.
This file is injected into the bundle, and when using snapshot testing on CI (with coverage enabled), it injects instrumented code, thus making inconsistent matching on local and CI tests.
yehor-manzhula
approved these changes
Jan 2, 2025
blackrabbit99
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.