-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solar Wind Models #18
Merged
stevertaylor
merged 28 commits into
nanograv:master
from
Hazboun6:jsh-solar_wind_models
Apr 26, 2019
Merged
Solar Wind Models #18
stevertaylor
merged 28 commits into
nanograv:master
from
Hazboun6:jsh-solar_wind_models
Apr 26, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed mean subtraction from determinsitic_solar_dm.
Added missing Tspan flag to chromatic_noise_block
I have removed all of the references to the solar wind code, except in the
#Here there are 11 bins
n_earth = parameter.Uniform(0,20,size=11)('n_earth')
sw = SW.solar_wind(n_earth=n_earth,n_earth_bins=11,t_init=tmin,t_final=tmax)
mean_sw = deterministic_signals.Deterministic(sw, name='mean_sw')
n_earth = SW.ACE_SWEPAM_Parameter()('n_earth')
sw = SW.solar_wind(n_earth=n_earth)
mean_sw = deterministic_signals.Deterministic(sw, name='mean_sw')
dm_sw_basis = SW.createfourierdesignmatrix_solar_dm(nmodes=15,Tspan=Tspan)
dm_sw_prior = utils.powerlaw(log10_A=log10_A_dm_sw, gamma=gamma_dm_sw)
gp_sw = gp_signals.BasisGP(priorFunction=dm_sw_prior, basisFunction=dm_sw_basis, name='gp_sw')
dm_block = SW.solar_wind_block(Tspan=Tspan, include_dmgp=True) |
Re: point 1, see issue #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new version of the solar wind model, that I am planning on writing up a methods paper on. This pull request includes a number of changes. The first is actually a change to
model_utils.py
.PTMCMCSampler
only takes a standard set of object inputs. If someone can think of a cleaner, or more specific way to do this please make suggestions. @paulthebaker or @svigeland Any thoughts on this?