Merge pull request #134 from ripienaar/misc_noack

minor fixes
nats-io · Oct 16, 2020 · aef00ea · aef00ea
2 parents 002482f + 8aaab34
commit aef00ea
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -6,7 +6,7 @@ This package is the underlying library for the `nats` CLI, our Terraform provide
 
 **NOTE**: This package is under development, while JetStream is in Preview we make no promises about the API stability of this package.
 
-[![Go Doc](https://pkg.go.dev/badge/nats.io/jsm.go)](https://pkg.go.dev/nats.io/jsm.go)
+[![Go Doc](https://pkg.go.dev/badge/github.com/nats-io/jsm.go)](https://pkg.go.dev/github.com/nats-io/jsm.go)
 
 ## Features
 
@@ -205,7 +205,7 @@ schemaType, _ := api.SchemaTypeForMessage(m.Data)
 schema, _ := api.Schema(schemaType)
 ```
 
-Several other Schema related helpers exist to search Schemas, fine URLs and more.  See the `api` [![Reference](https://pkg.go.dev/badge/nats.io/jsm.go/api)](https://pkg.go.dev/github.com/nats-io/jsm.go/api).
+Several other Schema related helpers exist to search Schemas, fine URLs and more.  See the `api` [![Reference](https://pkg.go.dev/badge/github.com/nats.io/jsm.go/api)](https://pkg.go.dev/github.com/nats-io/jsm.go/api).
 
 ### Parsing Message Content
 

diff --git a/stream_pager.go b/stream_pager.go
@@ -130,7 +130,6 @@ func (p *StreamPager) NextMsg(ctx context.Context) (msg *nats.Msg, last bool, er
 
 	select {
 	case msg := <-p.q:
-		msg.Ack()
 		p.seen++
 
 		return msg, p.seen == p.pageSize, nil
@@ -141,7 +140,6 @@ func (p *StreamPager) NextMsg(ctx context.Context) (msg *nats.Msg, last bool, er
 
 func (p *StreamPager) createConsumer() error {
 	cops := []ConsumerOption{
-		AcknowledgeExplicit(),
 		DurableName(fmt.Sprintf("jsm_stream_pager_%d%d", os.Getpid(), time.Now().UnixNano())),
 	}