feat(controller-runtime): Implement stream controller #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Controllers and tests are based on files generated by operator-sdk. Adds a minimal test suite for the controllers with a etcd test env and a test nats jetStream server to test against.
See TODOs on what still needs to be implemented.
Use a single use client on every connection. This should be replaced by a client pool in the future.
Setting CAs: []string{*ca} resulted in []string{""} when no CA was set, leading to an error when creating clients.
- Trigger only on generation changes - Split initialization and create into separate calls to Reconcile
Instead check for preventUpdate. Introduced during refactor.
Prefix with stream to prevent conflict with other resources.
samuelattwood
approved these changes
Dec 18, 2024
- Add note on opts.Account - Add comment on possible feature to expose TLSFirst in the spec.
adriandieter
commented
Dec 18, 2024
|
|
||
| // Takes opts values if present | ||
| cfg := &NatsConfig{ | ||
| CRDConnect: false, |
There was a problem hiding this comment.
I just noticed that CRDConnect is always false for the clients.
Do you think we need something like this for setting the value according to base config and opts?
Set CRDConnect to the base config value, but set it to false if spec config should overwrite it:
cfg.CRDConnect = c.config.CRDConnect
if opts.Creds != "" ||
opts.Nkey != "" ||
len(opts.TLS.RootCAs) > 0 ||
opts.TLS.ClientCert != "" ||
opts.TLS.ClientKey != "" {
cfg.CRDConnect = false
}Reword log messages.
samuelattwood
merged commit 0f218f5
into
nats-io:feature/controller-runtime
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements reconciliation of stream resources in the stream controller
Adds a base JetstreamController for nats/jetstream functionality shared between controllers, like initializing a jetStream client for the current call.
Adds test suit using envtest and embedded nats servers.
Fixes tests failing due to missing k8s binaries.