Update NATS server to 2.10.4 #126
Conversation
Signed-off-by: Byron Ruth <[email protected]>
| @@ -1,7 +1,7 @@ | |||
| #!/usr/bin/env bash | |||
| set -ex | |||
|
|
|||
| ver=(NATS_SERVER 2.9.23) | |||
There was a problem hiding this comment.
I think this one has to be 2.9.23 actually
There was a problem hiding this comment.
Hrm. Let me check, I think the tests run on which ever version is currently being released. At least that is how it worked before.
There was a problem hiding this comment.
There are only one set of tests for both versions so which is being released is the one that would replace this value. The 2.9.x one has not changed, so no need for testing that.
I believe you did a dual release before correct, so both versions needed to be tested?
There was a problem hiding this comment.
For posterity, noting @wallyqs and I spoke and no need to change since only one version bump is happening.
| @@ -3,7 +3,7 @@ Set-PSDebug -Trace 2 | |||
| # Exit on error. | |||
| $ErrorActionPreference = "Stop" | |||
|
|
|||
| $ver = "NATS_SERVER 2.9.23".Split(" ")[1] | |||
| @@ -3,7 +3,7 @@ Set-PSDebug -Trace 2 | |||
| # Exit on error. | |||
| $ErrorActionPreference = "Stop" | |||
|
|
|||
| $ver = 'NATS_SERVER 2.9.23'.Split(' ')[1] | |||
There was a problem hiding this comment.
also has to remain 2.9.23 I think
No description provided.