Skip to content

Commit

Permalink
Skip specific test for NATS servers earlier than v2.10
Browse files Browse the repository at this point in the history
This commit updates the KeyValueStoreTest to skip the Test_CombinedSources test for NATS server versions earlier than 2.10 since some of the mirroring features are introduced with 2.10. It also removes unnecessary retry delay and timeout parameters from the test configuration.
  • Loading branch information
mtmk committed Sep 19, 2024
1 parent 2f95598 commit 419cf3f
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions tests/NATS.Client.KeyValueStore.Tests/KeyValueStoreTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ public async Task TestDirectMessageRepublishedSubject()
Assert.Equal("tres", kve3.Value);
}

[Fact]
[SkipIfNatsServer(versionEarlierThan: "2.10")]
public async Task Test_CombinedSources()
{
await using var server = NatsServer.StartJS();
Expand Down Expand Up @@ -687,9 +687,7 @@ await Retry.Until(
}

return true;
},
retryDelay: TimeSpan.FromSeconds(3),
timeout: TimeSpan.FromSeconds(30));
});

var entryA = await storeCombined.GetEntryAsync<string>("ss1_a");
var entryB = await storeCombined.GetEntryAsync<string>("ss2_b");
Expand Down

0 comments on commit 419cf3f

Please sign in to comment.