Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object store interfaces and missing features #195

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

mtmk
Copy link
Collaborator

@mtmk mtmk commented Nov 8, 2023

Defined Object Store public interfaces to indicate what is supported and help with dependency injection and unit testing scenarios.

Also implemented missing features:

  • Add bucket link
  • Seal
  • List
  • Get status

contributes to #105

Defined Object Store public interfaces to indicate what is supported
and help with dependency injection and unit testing scenarios.

Also implemented missing features:
* Add bucket link
* Seal
* List
* Get status
@mtmk mtmk requested a review from caleblloyd November 8, 2023 14:32
Copy link
Collaborator

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk mtmk merged commit ba9fde8 into main Nov 8, 2023
9 checks passed
@mtmk mtmk deleted the obj-store-updates branch November 8, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants