Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordered consumer sequence and clean-up fix #198

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

mtmk
Copy link
Collaborator

@mtmk mtmk commented Nov 9, 2023

  • Fixed sequence number bug when recreating consumers.
  • Also made sure the ephemeral consumer was deleted on errors.
  • Also added a memory test to make sure consumer subscription isn't being GCed prematurely.

* Fixed sequence number bug when recreating consumers.
* Also made sure the ephemeral consumer was deleted on errors.
* Also added a memory test to make sure consumer subscription isn't
  being GCed prematurely.
@mtmk mtmk requested a review from caleblloyd November 9, 2023 15:39
Copy link
Collaborator

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk mtmk merged commit 0d2426f into main Nov 9, 2023
9 checks passed
@mtmk mtmk deleted the ordered-consumer-seq-fix branch November 9, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants