Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconnect backoff #211

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Reconnect backoff #211

merged 3 commits into from
Nov 16, 2023

Conversation

mtmk
Copy link
Collaborator

@mtmk mtmk commented Nov 15, 2023

To help minimize the impact on the servers during failures.

@mtmk
Reconnect backoff
577530c 
To help minimize the impact on the servers during failures.
@mtmk mtmk requested a review from caleblloyd November 15, 2023 20:17
@mtmk mtmk mentioned this pull request Nov 15, 2023
Merged
caleblloyd
caleblloyd approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caleblloyd
Copy link
Collaborator

Only other comments is that with ReconnectWaitMax set by default, it might make more sense to rename ReconnectWait to ReconnectWaitMin

@mtmk mtmk merged commit c6ffcce into main Nov 16, 2023
9 checks passed
@mtmk mtmk deleted the reconnect-backoff branch November 16, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleblloyd caleblloyd caleblloyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtmk @caleblloyd