-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds type-forwarders NET 5.0+ #641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @VaticanUK
ouch! sorry @VaticanUK forgot to mention. Could you rebase and sign your commit please? (You will need to force push and don't worry about my commit, that can be absorbed as well) Otherwise I can't merge since it's a CNCF requirement and we have a rule for it in repo settings. |
720fe3c
to
1cb294e
Compare
Ok, got there in the end :) |
* Add placement configuration to key-value and object store (#650) * Bump System.Text.Json from 8.0.4 to 8.0.5 in /src/NATS.Client.Core (#649) * Add other client extensions (#637) * Add Domain support for stream mirroring and sourcing and KV full support for the same. (#631) * Add type-forwarders NET 5.0+ (#641) * Add JetStream NATS Client Extensions (#598)
* Add placement configuration to key-value and object store (#650) * Bump System.Text.Json from 8.0.4 to 8.0.5 in /src/NATS.Client.Core (#649) * Add other client extensions (#637) * Add Domain support for stream mirroring and sourcing and KV full support for the same. (#631) * Add type-forwarders NET 5.0+ (#641) * Add JetStream NATS Client Extensions (#598)
Adds missing type forwarders to fix
MissingMethodExceptions
when this library is consumed by a .NET standard library, which is then consumed by a > .NET 5 appResolves #640