Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade xunit to v3 #710

Merged
merged 4 commits into from
Jan 12, 2025
Merged

upgrade xunit to v3 #710

merged 4 commits into from
Jan 12, 2025

Conversation

caleblloyd
Copy link
Collaborator

@caleblloyd
upgrade xunit to v3
73e0e8d 
Signed-off-by: Caleb Lloyd <[email protected]>
@caleblloyd
revise references
fb408ae 
Signed-off-by: Caleb Lloyd <[email protected]>
@caleblloyd
Copy link
Collaborator Author

Looks like NATS.Client.Core.Tests.NatsConnectionTestWss.OnSocketAvailableAsync_ShouldBeInvokedOnReconnection may be a flapper

@caleblloyd caleblloyd requested a review from mtmk January 12, 2025 18:07
@mtmk
Copy link
Collaborator

mtmk commented Jan 12, 2025

Looks like NATS.Client.Core.Tests.NatsConnectionTestWss.OnSocketAvailableAsync_ShouldBeInvokedOnReconnection may be a flapper

yes that's one of the new flappers. just kicked a rerun.

mtmk
mtmk approved these changes Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @caleblloyd

@mtmk mtmk merged commit 2d3a347 into main Jan 12, 2025
13 checks passed
@mtmk mtmk deleted the xunit-v3 branch January 12, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtmk mtmk mtmk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caleblloyd @mtmk