Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topo.dotprops added #459

Merged
merged 3 commits into from
May 18, 2021
Merged

topo.dotprops added #459

merged 3 commits into from
May 18, 2021

Conversation

dokato
Copy link
Contributor

@dokato dokato commented May 18, 2021

Needed for natverse/nat.nblast#44 to work.

See also:
natverse/nat.nblast#43

@coveralls
Copy link

coveralls commented May 18, 2021

Coverage Status

Coverage increased (+0.06%) to 81.487% when pulling 45112ee on dokato:topodotp into 2da55fa on natverse:master.

Copy link
Collaborator

@jefferis jefferis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I've just made a few small comments. Only other thing would be to add a test. Thanks! Greg.

R/dotprops.R Outdated Show resolved Hide resolved
R/dotprops.R Outdated Show resolved Hide resolved
R/dotprops.R Show resolved Hide resolved
R/dotprops.R Outdated Show resolved Hide resolved
@dokato
Copy link
Contributor Author

dokato commented May 18, 2021

Thanks @jefferis for your comments. All fixed, I added some test too and rebuilt the docs.

@jefferis jefferis merged commit 49d06c6 into natverse:master May 18, 2021
@jefferis
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants