refactor: remove BEM-specific code and generalize PDF processing #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
KevinJBoyer
approved these changes
Dec 17, 2024
yoomlam
reviewed
Dec 17, 2024
app/src/ingestion/pdf_stylings.py
Outdated
| @@ -319,15 +319,11 @@ def _create_phrase(self, parent_node: Element | None, child: Text) -> Phrase | N | |||
| return Phrase(text=child.data, bold=bolded) | |||
|
|
|||
|
|
|||
| class BemTagExtractor(TagExtractor): | |||
| class GenericTagExtractor(TagExtractor): | |||
There was a problem hiding this comment.
I wouldn't call this Generic since it was implemented specifically for BEM pdfs. Either remove it entirely or leave it as is.
There was a problem hiding this comment.
Will remove -- I noticed this file was all specific BEM if I'm not mistaken.
There was a problem hiding this comment.
Removed this file pdf_stylings.py as it was only used by BEM
yoomlam
reviewed
Dec 17, 2024
app/src/ingest_policy_pdfs.py
Outdated
There was a problem hiding this comment.
@KevinJBoyer Should this file go away as well (probably in another PR)? I think this was for some Michigan PDF that was different from BEM pdfs -- #31
ccheng26
approved these changes
Dec 18, 2024
fg-nava
force-pushed
the
DST-620-remove-bem-code-functions
branch
from
9a4e794 to
8db3a3d
Compare
yoomlam
approved these changes
Dec 18, 2024
app/src/format.py
Outdated
Comment on lines
95
to
68
| def _get_bem_documents_to_show( | ||
| def _get_documents_to_show( |
There was a problem hiding this comment.
If this is not called by any remaining code, remove it.
Co-authored-by: Yoom Lam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://navalabs.atlassian.net/browse/DST-620
Changes
Removed BEM (Bridges Eligibility Manual) specific components:
BridgesEligibilityManualEngineclass from chat engineBemFormattingConfigclass and related formatting logicbem_util.py)ingest_bem_pdfs.py,ingest_policy_pdfs.py)Updated tests:
Updated configurations:
Context for reviewers
PR removes all Bridges Eligibility Manual (BEM) specific code as part of our effort to make the codebase more generic and maintainable. The PDF processing functionality has been generalized to work with any PDF document, not just BEM files.
Testing
make init startto start the application