Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide direct link to text #162

Merged
merged 11 commits into from
Jan 2, 2025
Merged

feat: Provide direct link to text #162

merged 11 commits into from
Jan 2, 2025

Conversation

ccheng26
Copy link
Contributor

Ticket

https://navalabs.atlassian.net/browse/DST-565

Changes

Added uri formatter to return highlighted text when navigating to html site

Context for reviewers

This won't work for the socialbenefitsnavigator site. The accordions hide the text content and the direct links don't work unless you expand the values and refresh

Testing

  1. run make start
  2. query the api via localhost:8000/api/query using similar payload to the following:
    {
    "session_id": "your session name",
    "new_session": "true",
    "message": "What programs are available to me as a low income parent?"
    }
  3. find a https://edd.ca.gov/en/ link, socialbenefitsnavigator links have all answers in accordions, with the first link there may be text outside of an accordion to view highlighted text

Copy link

github-actions bot commented Dec 19, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2829 2527 89% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
app/src/chat_api.py 96% 🟢
app/src/util/string_utils.py 91% 🟢
TOTAL 93% 🟢

updated for commit: 94b717e by action🐍

Copy link
Contributor

@KevinJBoyer KevinJBoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

app/src/chat_api.py Outdated Show resolved Hide resolved
@ccheng26 ccheng26 merged commit d3db181 into main Jan 2, 2025
4 checks passed
@ccheng26 ccheng26 deleted the linkToText branch January 2, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants