-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ensure UI feedback message for batch processing completion #170
Merged
fg-nava
merged 9 commits into
DST-688-batch-processing-limitations
from
DST-709-ui-feedback-batch-processing
Jan 10, 2025
Merged
fix: Ensure UI feedback message for batch processing completion #170
fg-nava
merged 9 commits into
DST-688-batch-processing-limitations
from
DST-709-ui-feedback-batch-processing
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
fg-nava
commented
Jan 9, 2025
yoomlam
changed the base branch from
main
to
DST-688-debug-batch-processing-limitations
January 9, 2025 23:18
yoomlam
changed the title
Dst 709 UI feedback batch processing
fix: Ensure UI feedback message for batch processing completion
Jan 9, 2025
yoomlam
changed the base branch from
DST-688-debug-batch-processing-limitations
to
DST-688-batch-processing-limitations
January 9, 2025 23:19
yoomlam
reviewed
Jan 9, 2025
yoomlam
reviewed
Jan 9, 2025
yoomlam
approved these changes
Jan 9, 2025
…ions' into DST-709-ui-feedback-batch-processing
ccheng26
reviewed
Jan 10, 2025
ccheng26
approved these changes
Jan 10, 2025
fg-nava
merged commit Jan 10, 2025
025092d
into
DST-688-batch-processing-limitations
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: resolve missing batch processing UI feedback message
Ticket
https://navalabs.atlassian.net/browse/DST-709
Changes
chainlit.py
to ensure completion status is visible in UIContext for reviewers
The batch processing feature was not showing completion messages in the UI, even though they were being logged successfully. Investigation showed that messages with author "backend" were not consistently visible in the Chainlit UI.
Key changes:
This PR is part of improving the batch processing feature's user experience, following the fix for CPU usage issues in DST-688.
Testing
Tested locally with the following scenarios:
Uploaded a CSV file with valid questions
Uploaded a CSV without a "question" column
Verified all status messages appear in sequence:
Screenshot: