fix ci: Set test coverage thresholds #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
KevinJBoyer
approved these changes
Oct 1, 2024
| @@ -56,3 +56,6 @@ jobs: | |||
| sourceDir: app | |||
| coverageFile: app/coverage_report.xml | |||
| token: ${{ secrets.GITHUB_TOKEN }} | |||
| thresholdAll: 0.8 | |||
| thresholdNew: 0.9 | |||
| thresholdModified: 0.8 | |||
There was a problem hiding this comment.
Suggested change
| thresholdModified: 0.8 | |
| thresholdModified: 0.8 |
Is this file specific -- in other words, does this mean edits to a file with no pre-existing coverage will fail this check if the PR doesn't take coverage from 0 -> 80%?
There was a problem hiding this comment.
I added an exclusion for app.py:
2f13d8e
There was a problem hiding this comment.
So, I'd recommend that files with no pre-existing coverage be added to the omit list rather than changing the threshold.
ccheng26
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Slack
Changes
Set test coverage thresholds.
The PR check will fail if thresholds aren't met.
Testing
Tested here: #83 (comment)
which now shows a red status.