Removes evidently feature flags #142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@coilysiren looks good but you still need to remove /feature-flags from app.py so this doesn't happen |
coilysiren
added a commit
to navapbc/template-infra
that referenced
this pull request
Nov 27, 2024
## Ticket Relates to #781 Closes #791 ## Changes - removes evidently from the infrastructure layer - removes evidently from the application layer ## Testing navapbc/platform-test#142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Relates to navapbc/template-infra#791, navapbc/template-infra#781
Changes
Testing
Given that the PR is purely removing things, I feel like CI passing should be a sufficient test here. Let me know if there's some specific code path I should test, though.
Preview environment for app