Use underscores in Terraform file names instead of dashes #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
system-notifications.tf -> system_notifications.tf
daphnegold
added a commit
to navapbc/template-infra
that referenced
this pull request
Jan 9, 2025
## Ticket Resolves #739 ## Changes - Swapped dashes for underscores in the 2 remaining files that were inconsistent - Added info to style guide ## Testing `find . -type f -name '*.tf' | awk -F/ '{print $NF}' | grep -- '-'` [Platform Test PR](navapbc/platform-test#152) <!-- app - begin PR environment info --> ## Preview environment for app - Service endpoint: http://p-152-app-dev-936383488.us-east-1.elb.amazonaws.com - Deployed commit: dd08a9353c1d11202e5222d52c3c44e8042de11e <!-- app - end PR environment info -->
|
Done in navapbc/template-infra#828 (@daphnegold fyi once we merge the template-infra PR we can close out the platform-test PR with a comment and then delete the branch. Closing the PR will also cause the PR environment to be cleaned up) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #739
Changes
Testing
find . -type f -name '*.tf' | awk -F/ '{print $NF}' | grep -- '-'Preview environment
♻️ Environment destroyed ♻️