Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for-jdk17 #263

Merged
Merged

Conversation

CorvusYe
Copy link
Collaborator

As mentioned in #216 and #262, a new branch has been created to support springboot3.x.

And thanks to @omar-araboghli 's contribution in #217.

This branch currently incorporates 1.2.0-beta features from #217
and will continue to incorporate features from the main branch in the future.
And release the version in the form of a separate tag.

1244453393 and others added 30 commits September 6, 2023 18:22
补充了相关文档
添加了相关代码例子
This reverts commit 736e56c.
the upstream vitepress change breaks the build
now stick to a working version first
quickfix: ngbatis doc quick broken build
- add en docs for ng.include
- add gh reaction to ensure change doesn't break docs build
- scoped the ci trigger condition for java and doc changes in PR
- formated existing docs
- added ci hook to enforce it, this will be helpful to
  fix issues before the doc build failed
ci: add .mk linter and formater
fix maven_args in action-maven-publish@v1
…gh_action

ci drop old gh action, use mvn directly
@CorvusYe CorvusYe requested review from wey-gu and Nicole00 November 21, 2023 15:45
Copy link
Member

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡🤩
could we co-author this change with @omar-araboghli ?

@omar-araboghli
Copy link

🫡🤩 could we co-author this change with @omar-araboghli ?

I think my first commit is visible in the commits history of the PR. Thank you for the consideration and your great work guys! :)

@CorvusYe
Copy link
Collaborator Author

🫡🤩 could we co-author this change with @omar-araboghli ?

I think my first commit is visible in the commits history of the PR. Thank you for the consideration and your great work guys! :)

For important milestones such as supporting jdk17 and springboot 3.x, I have only resolved some conflicts in them. Your contribution is very important for us.

I personally prefer to merge #217 into the for-jdk17 branch as a starting point, if possible.

If it weren't for you, I might not have started. Thanks again. @omar-araboghli

@wey-gu
Copy link
Member

wey-gu commented Nov 22, 2023

I really love the community😄

@CorvusYe CorvusYe changed the base branch from for-jdk17 to for-jdk17-resolve-conflicts November 24, 2023 12:13
@CorvusYe CorvusYe merged commit 2c07bc3 into nebula-contrib:for-jdk17-resolve-conflicts Nov 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants