Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LaunchImage and Blurr together in IOS #38

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

eddyuan
Copy link

@eddyuan eddyuan commented Jul 13, 2022

Merged from stevenspiel and made some changes to make both LaunchImage and Blur work together (Image on top of Blur)

Copy link
Owner

@neckaros neckaros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this merge request! Please just update the readme as commented.
I don't have a Mac to test but the code seems good and I will trust your tests.

@@ -1,16 +1,22 @@
**previously nammed secure_window**

Forked from [neckaros](https://github.com/neckaros/secure_application) & [stevenspiel](https://github.com/stevenspiel/secure_application)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it would no longer be a fork could you remove this part and merge the extended features please?

### Use useLaunchImageIOS
Open your_project/ios in xcode, add LaunchImage if not already exist

<img src="https://github.com/eddyuan/secure_application/blob/master/example/screenshot/xcode_setting.png?raw=true"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CAN you use the link for target repo please?

@minhdanh
Copy link

Hi @eddyuan any updates for this PR? Is it read to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants