Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#2212): support experimental type info component #2349

Draft
wants to merge 48 commits into
base: master
Choose a base branch
from

Conversation

DjordyKoert
Copy link
Collaborator

@DjordyKoert DjordyKoert commented Oct 4, 2024

Q A
Bug fix? yes/no
New feature? yes
Deprecations? yes/no
Issues Closes #2212

Adds support for Symfony's experimental type-info component for describing properties.

DjordyKoert added a commit that referenced this pull request Oct 17, 2024
Cleans up the return value while determining if a class needs to be
described.

Taken from #2349
# Conflicts:
#	src/ModelDescriber/ObjectModelDescriber.php
#	tests/Functional/Fixtures/MapQueryStringController.json
#	tests/Functional/Fixtures/MapRequestPayloadController.json
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 6.32911% with 148 lines in your changes missing coverage. Please review.

Project coverage is 85.26%. Comparing base (13408ab) to head (227bf3b).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/TypeDescriber/ChainDescriber.php 0.00% 19 Missing ⚠️
src/TypeDescriber/IntersectionDescriber.php 0.00% 17 Missing ⚠️
src/TypeDescriber/UnionDescriber.php 0.00% 17 Missing ⚠️
src/TypeDescriber/ArrayDescriber.php 0.00% 14 Missing ⚠️
src/TypeDescriber/ObjectClassDescriber.php 0.00% 14 Missing ⚠️
src/ModelDescriber/ObjectModelDescriber.php 31.25% 11 Missing ⚠️
src/TypeDescriber/DictionaryDescriber.php 0.00% 8 Missing ⚠️
src/TypeDescriber/ListDescriber.php 0.00% 8 Missing ⚠️
src/TypeDescriber/FloatDescriber.php 0.00% 6 Missing ⚠️
src/TypeDescriber/ObjectDescriber.php 0.00% 6 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2349      +/-   ##
==========================================
- Coverage   89.53%   85.26%   -4.27%     
==========================================
  Files          78       93      +15     
  Lines        2915     3068     +153     
==========================================
+ Hits         2610     2616       +6     
- Misses        305      452     +147     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Symfony 7.1] support for TypeInfo component
1 participant