Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup Areas annotation #2431

Merged
merged 4 commits into from
Jan 19, 2025
Merged

chore: cleanup Areas annotation #2431

merged 4 commits into from
Jan 19, 2025

Conversation

DjordyKoert
Copy link
Collaborator

Description

Cleans up the Area annotation/attribute to trigger a deprecation warning whenever a list of strings isn't passed.

What type of PR is this? (check all applicable)

  • Bug Fix
  • Feature
  • Refactor
  • Deprecation
  • Breaking Change
  • Documentation Update
  • CI

Checklist

  • I have made corresponding changes to the documentation (docs/)
  • I have made corresponding changes to the changelog (CHANGELOG.md)

@DjordyKoert DjordyKoert force-pushed the cleanup-area branch 2 times, most recently from ad9d26e to f776b2c Compare January 19, 2025 16:31
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (3aaa734) to head (52c3219).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2431      +/-   ##
==========================================
+ Coverage   90.12%   90.18%   +0.06%     
==========================================
  Files          94       94              
  Lines        3067     3067              
==========================================
+ Hits         2764     2766       +2     
+ Misses        303      301       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DjordyKoert DjordyKoert merged commit cdc855e into master Jan 19, 2025
26 checks passed
@DjordyKoert DjordyKoert deleted the cleanup-area branch January 19, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant