Remove dependency on common; split APOC core and APOC extended up to be less reliant on eachother #4259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gem-neo4j
force-pushed
the
dev_remove_common
branch
2 times, most recently
from
56f0610 to
7127cf3
Compare
…be less reliant on eachother
gem-neo4j
force-pushed
the
dev_remove_common
branch
from
7127cf3 to
18fedd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We break extended a lot by changing things in common and not realising it affects extended. We have also had issues from users having issues with using core as a module based on the split. I have a branch on core which moves everything into core. This currently is referencing that branch as a module for testing purposes.