-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update REVOKE information to say that in cypher 25 you get errors for impossible revoke commands #2009
base: dev
Are you sure you want to change the base?
Conversation
f0c2617
to
41bf15b
Compare
@renetapopova Hello, what do you think, should we just document the differences in Cypher 25 like this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good that we mention it here. I added an editorial suggestion.
@@ -179,7 +179,7 @@ Use `REVOKE` if you want to remove a privilege. | |||
==== | |||
|
|||
Common errors, such as misspellings or attempts to revoke privileges that have not been granted or denied, will lead to notifications. | |||
Some of these notifications may be replaced with errors in a future major version of Neo4j. | |||
Notifications for impossible `REVOKE` commands where any of the user, role or database does not exist have been replaced with errors in Cypher 25. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notifications for impossible `REVOKE` commands where any of the user, role or database does not exist have been replaced with errors in Cypher 25. | |
In Cypher 25, notifications for impossible `REVOKE` commands, where a user, a role, or a database does not exist, have been replaced with errors. |
@@ -187,7 +187,7 @@ Use `REVOKE` if you want to remove a privilege. | |||
==== | |||
|
|||
Common errors, such as misspellings or attempts to revoke privileges that have not been granted or denied, will result in notifications. | |||
Some of these notifications may be replaced with errors in a future major version of Neo4j. | |||
Notifications for impossible `REVOKE` commands where any of the user, role or database does not exist have been replaced with errors in Cypher 25. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
@@ -814,7 +814,7 @@ REVOKE ROLES role1, role2 FROM user1, user2, user3 | |||
---- | |||
|
|||
Common errors, such as misspellings or attempts to revoke roles from users who have not been granted those roles, will lead to notifications. | |||
Some of these notifications may be replaced with errors in a future major version of Neo4j. | |||
Notifications for impossible `REVOKE` commands where any of the user, role or database does not exist have been replaced with errors in Cypher 25. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
This PR includes documentation updates Updated pages: |
@@ -179,7 +179,7 @@ Use `REVOKE` if you want to remove a privilege. | |||
==== | |||
|
|||
Common errors, such as misspellings or attempts to revoke privileges that have not been granted or denied, will lead to notifications. | |||
Some of these notifications may be replaced with errors in a future major version of Neo4j. | |||
In Cypher 25, notifications for impossible `REVOKE` commands, where a user, a role, or a database does not exist, have been replaced with errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have any examples of the Cypher 5 behaviour that we should now prepend with CYPHER 5
and add notes on that they would fail in Cypher 25? Or is these 3 sentences the only thing on this topic that we had? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can not find anything more on this topic than those 3 sentences. Looks like all the examples we have are successful ones, not examples that will fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need something in the additions/removals section in the cypher manual about this as well? (I don't think we have one for the operations manual yet and that we still add things there)
@Hunterness Yes, you are right. Created a PR for that: neo4j/docs-cypher#1170 |
We are working on creating a page about Deprecations, removals, and changes related to the Neo4j server. |
Not sure this is the right way to do it, mention Cypher 25 in the operations manual, or is there a way to specify which cypher version to see documentation for?