Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update REVOKE information to say that in cypher 25 you get errors for impossible revoke commands #2009

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

HannesSandberg
Copy link
Contributor

Not sure this is the right way to do it, mention Cypher 25 in the operations manual, or is there a way to specify which cypher version to see documentation for?

@HannesSandberg HannesSandberg force-pushed the dev-errors-for-impossible-revoke-commands-in-cypher25 branch from f0c2617 to 41bf15b Compare January 15, 2025 10:18
@HannesSandberg
Copy link
Contributor Author

@renetapopova Hello, what do you think, should we just document the differences in Cypher 25 like this?

Copy link
Contributor

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good that we mention it here. I added an editorial suggestion.

@@ -179,7 +179,7 @@ Use `REVOKE` if you want to remove a privilege.
====

Common errors, such as misspellings or attempts to revoke privileges that have not been granted or denied, will lead to notifications.
Some of these notifications may be replaced with errors in a future major version of Neo4j.
Notifications for impossible `REVOKE` commands where any of the user, role or database does not exist have been replaced with errors in Cypher 25.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Notifications for impossible `REVOKE` commands where any of the user, role or database does not exist have been replaced with errors in Cypher 25.
In Cypher 25, notifications for impossible `REVOKE` commands, where a user, a role, or a database does not exist, have been replaced with errors.

@@ -187,7 +187,7 @@ Use `REVOKE` if you want to remove a privilege.
====

Common errors, such as misspellings or attempts to revoke privileges that have not been granted or denied, will result in notifications.
Some of these notifications may be replaced with errors in a future major version of Neo4j.
Notifications for impossible `REVOKE` commands where any of the user, role or database does not exist have been replaced with errors in Cypher 25.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@@ -814,7 +814,7 @@ REVOKE ROLES role1, role2 FROM user1, user2, user3
----

Common errors, such as misspellings or attempts to revoke roles from users who have not been granted those roles, will lead to notifications.
Some of these notifications may be replaced with errors in a future major version of Neo4j.
Notifications for impossible `REVOKE` commands where any of the user, role or database does not exist have been replaced with errors in Cypher 25.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

@neo-technology-commit-status-publisher
Copy link
Collaborator

This PR includes documentation updates
View the updated docs at https://neo4j-docs-operations-2009.surge.sh

Updated pages:

@Hunterness Hunterness self-assigned this Jan 16, 2025
@@ -179,7 +179,7 @@ Use `REVOKE` if you want to remove a privilege.
====

Common errors, such as misspellings or attempts to revoke privileges that have not been granted or denied, will lead to notifications.
Some of these notifications may be replaced with errors in a future major version of Neo4j.
In Cypher 25, notifications for impossible `REVOKE` commands, where a user, a role, or a database does not exist, have been replaced with errors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have any examples of the Cypher 5 behaviour that we should now prepend with CYPHER 5 and add notes on that they would fail in Cypher 25? Or is these 3 sentences the only thing on this topic that we had? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not find anything more on this topic than those 3 sentences. Looks like all the examples we have are successful ones, not examples that will fail.

Copy link
Contributor

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need something in the additions/removals section in the cypher manual about this as well? (I don't think we have one for the operations manual yet and that we still add things there)

@HannesSandberg
Copy link
Contributor Author

@Hunterness Yes, you are right. Created a PR for that: neo4j/docs-cypher#1170

@renetapopova
Copy link
Contributor

Do we need something in the additions/removals section in the cypher manual about this as well? (I don't think we have one for the operations manual yet and that we still add things there)

We are working on creating a page about Deprecations, removals, and changes related to the Neo4j server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants