TASK: Correctly mark nullable method parameters as nullable

[Benjamin-K]

Review instructions

This PR will correctly mark implicit nullable types as nullable, which will remove deprecation warnings in PHP 8.4.

Checklist

• Code follows the PSR-2 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

[dlubitz]

Thank you @Benjamin-K. This is great. But we need to check why the tests are failing.

[Benjamin-K]

@dlubitz I fixed the PR already. The only thing it now complains about is that I updated the bracket style of functions:

# before
function name() {}

# after
function name()
{
}

which is from the PSR-12: Extended Coding Style

[dlubitz]

No, you changed it the other way around:

-    public function collectGarbage(): void
-    {
-    }
+    public function collectGarbage(): void {}

[mhsdesign]

which i think is correct, we dont use this shortsyntax because its not worth it ^^ having empty method bodys is rare either way and psr 12 prohibits it:

The opening brace MUST go on its own line, and the closing brace MUST go on the next line following the body.

To apply all style ci changes just use this :D

curl https://github.styleci.io/analyses/dj7o6p/diff | git apply -

[Benjamin-K]

No, you changed it the other way around:

-    public function collectGarbage(): void
-    {
-    }
+    public function collectGarbage(): void {}

You're right, sry. Seems like vscode does not use the full PSR-12 set. I fixed this now.

[dlubitz]

This is awesome. Thank you so much.
Even though you found so many places I found some additional while reviewing.

[dlubitz]

Suggested change

	function var_dump($variable, string $title = null, bool $return = false, ?bool $plaintext = null)
	function var_dump($variable, ?string $title = null, bool $return = false, ?bool $plaintext = null)

[dlubitz]

Suggested change

	public function validate(string $configurationType = null, ?string $path = null, array &$loadedSchemaFiles = []): Result
	public function validate(?string $configurationType = null, ?string $path = null, array &$loadedSchemaFiles = []): Result

[dlubitz]

Suggested change

	public function listCommand(string $source = null, ?string $target = null)
	public function listCommand(?string $source = null, ?string $target = null)

[dlubitz]

Suggested change

	public function listConnectedCommand(string $className = null, ?string $methodName = null): void
	public function listConnectedCommand(?string $className = null, ?string $methodName = null): void

[dlubitz]

Suggested change

	public function append(string $message, int $severity = LOG_INFO, $additionalData = null, string $packageKey = null, string $className = null, ?string $methodName = null): void
	public function append(string $message, int $severity = LOG_INFO, $additionalData = null, ?string $packageKey = null, ?string $className = null, ?string $methodName = null): void

[dlubitz]

Suggested change

	public function runDql(string $dql, int $hydrationMode = \Doctrine\ORM\Query::HYDRATE_OBJECT, int $firstResult = null, ?int $maxResult = null)
	public function runDql(string $dql, int $hydrationMode = \Doctrine\ORM\Query::HYDRATE_OBJECT, ?int $firstResult = null, ?int $maxResult = null)

[dlubitz]

Suggested change

	public function buildMethodArgumentsValidatorConjunctions($className, $methodName, array $methodParameters = null, ?array $methodValidateAnnotations = null)
	public function buildMethodArgumentsValidatorConjunctions($className, $methodName, ?array $methodParameters = null, ?array $methodValidateAnnotations = null)

[dlubitz]

Suggested change

	public function generateXsdCommand(string $phpNamespace, string $xsdNamespace = null, ?string $targetFile = null, string $xsdDomain = ''): void
	public function generateXsdCommand(string $phpNamespace, ?string $xsdNamespace = null, ?string $targetFile = null, string $xsdDomain = ''): void

[dlubitz]

Suggested change

	public function expandGenericPathPatternTests($package, $subPackage, $controller, $format, $templateRootPath, array $templateRootPaths = null, $partialRootPath, array $partialRootPaths = null, $layoutRootPath, ?array $layoutRootPaths = null, $bubbleControllerAndSubpackage, $formatIsOptional, $pattern, $expectedResult)
	public function expandGenericPathPatternTests($package, $subPackage, $controller, $format, $templateRootPath, ?array $templateRootPaths = null, $partialRootPath, ?array $partialRootPaths = null, $layoutRootPath, ?array $layoutRootPaths = null, $bubbleControllerAndSubpackage, $formatIsOptional, $pattern, $expectedResult)

[dlubitz]

Suggested change

	public function createUploadedFile(StreamInterface $stream, int $size = null, int $error = \UPLOAD_ERR_OK, string $clientFilename = null, ?string $clientMediaType = null): UploadedFileInterface
	public function createUploadedFile(StreamInterface $stream, ?int $size = null, int $error = \UPLOAD_ERR_OK, ?string $clientFilename = null, ?string $clientMediaType = null): UploadedFileInterface

[dlubitz]

I also stumbled over this rector rule, which should do the migration:
https://getrector.com/rule-detail/explicit-nullable-param-type-rector