Handle exceptions on entity flush #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdambekalns
reviewed
Jul 12, 2024
|
I've changed it as suggested to try/catch |
|
Gnah… |
|
Yep, that's all we get. 🤷♂️ |
|
@kitsunet What do you think? |
|
And the PHP version used for the tests needs to be raised… 🙈 |
|
I think we really shouldn't deal with te UOW at all, and need to refactor htis, but it's fine for me as a quick fix. |
kitsunet
approved these changes
Jul 12, 2024
|
by reading, I read the issues in doctrine and see how this works, not sure if there might be any side effects. |
dlubitz
changed the title
kdambekalns
approved these changes
Jul 12, 2024
kdambekalns
force-pushed
the
bugfix/35-entity-flush
branch
from
67e138d to
c7c8db4
Compare
dlubitz
force-pushed
the
bugfix/35-entity-flush
branch
from
c7c8db4 to
87783d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35
The entity states are changing during the single flushes of entities. And if we have to remove more than one entity this crashes now, due to the change in doctrine/orm.
In general I think we should get rid of the manually handling of entity persistance, as we can see in this case.
For now we check this state, before flushing to ensure, we do not try to flush a detatched entity.